Skip to content

add github action for version releases to Sonatype #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2025
Merged

add github action for version releases to Sonatype #996

merged 4 commits into from
May 6, 2025
+99 −9

Conversation

shijiesheng
Copy link
Member

@shijiesheng shijiesheng commented May 1, 2025 •
edited
Loading

What changed?

  • added a github action release.yaml on push-tag and manual triggers (For safety, currently it's only auto-push-to-staging-and-close mode and requires manual release on sonatype)
  • added gralde nexus plugin
  • bump version to 3.12.7-SNAPSHOT

Plan:
after it's tested against some version upgrade, we can switch mode to auto-release

Why?

Releasing requires PGP key access + sonatype access. These overheads slow down the release process

How did you test it?

Tested nexus plugin locally on staging repository
Test with act locally

act -j release --secret-file dummy
...
[Release to Maven Central/release]   ✅  Success - Main Publish to Sonatype OSSRH (Maven Central) [2m0.223553458s]
[Release to Maven Central/release] ⭐ Run Complete job
[Release to Maven Central/release] Cleaning up container for job release
[Release to Maven Central/release]   ✅  Success - Complete job
[Release to Maven Central/release] 🏁  Job succeeded

Screenshot 2025-05-01 at 3 12 35 PM

Potential risks

Release notes

Documentation Changes

@shijiesheng
Copy link
Member Author

integration test failed due to cadence-workflow/cadence#6881

3vilhamster
3vilhamster approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice to have automation here as we have on Go client.

@shijiesheng shijiesheng merged commit 3bc07bd into cadence-workflow:master May 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3vilhamster 3vilhamster 3vilhamster approved these changes

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@abhishekj720 abhishekj720 Awaiting requested review from abhishekj720 abhishekj720 is a code owner

@natemort natemort Awaiting requested review from natemort natemort is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shijiesheng @3vilhamster